Title [Bug: 21.5-b28] Bug in #'loop
Type defect Module core code 21.5
Severity inconvenience Platform N/A
Keywords needs doc Nosy List
These controls should only be changed by committers and tracker administrators.
Status done/needs work   Reason
Superseder   Submitted 2008-01-07.16:47:53
Priority normal   Assigned To

Created on 2008-01-19.04:58:06 by stephen, last changed 2008-01-19.10:47:28 by stephen.

msg435 [hidden] ([hidden]) Date: 2008-01-19.10:47:28
See also issue212.
msg121 [hidden] ([hidden]) Date: 2008-01-19.04:58:06
  Message-ID: <>
Aidan Kehoe writes:

 > Here's a tentative fix that I have yet to test in detail; the
 > SXEmacs folk and Sebastian in particular have a pretty
 > comprehensive test suite available, though, and I intend to get to
 > testing it soon.

Please import the test suite into our regression tests.

 > --- cl-macs.el~	Mon Jan  7 17:35:10 2008
 > +++ cl-macs.el	Mon Jan  7 17:37:58 2008
 > @@ -1183,1 +1183,1 @@
 > -		  (push (list 'consp temp) loop-body)
 > +		  (push temp loop-body)

I've checked the HyperSpec and the expansion of the test form.  (I
wish you would take these obvious steps *and* document them when
submitting a patch like this.)  This looks like it is correct FWIW.

However you should also fix the doc to warn that (a) it will signal an
error if the LIST is a dotted list, (b) it will infloop (and crash if
the body conses) if the LIST is a circular list, and (c) even if it
errors, side effects may be executed.

There are also a bunch of typos in the doc that you might want to fix
up while you're there.

XEmacs-Beta mailing list
Date User Action Args
2008-01-19 10:47:28stephensetstatus: new -> done/needs work
priority: normal
module: + core code 21.5
severity: inconvenience
keyword: + needs doc
platform: + N/A
type: defect
messages: + msg435
submitted: 2008-01-08.05:27:43 -> 2008-01-07.16:47:53
2008-01-19 10:45:00stephenlinkissue212 superseder
2008-01-19 04:58:06stephencreate