Issue557: Should `self-insert-command' protect itself from non-interactive calls?

classification

Title	Should `self-insert-command' protect itself from non-interactive calls?
Type	defect	Module	core code 21.4, core code 21.5
Severity	inconvenience	Platform	N/A
Keywords		Nosy List	stephen

explanation

process

These controls should only be changed by committers and tracker administrators.
Status	assigned	Reason
Superseder
Priority	normal	Assigned To

Created on 2009-08-18.08:25:48 by stephen, last changed 2009-08-18.08:25:48 by stephen.

msg1823

[hidden] ([hidden])

Date: 2009-08-18.08:25:48

If called as `(self-insert-command)', you get

Wrong type argument: natnump, nil

While it's hard to see a use for that, maybe for robustness we should change the 
line

    CHECK_NATNUM (count);

to

    CHECK_NATNUM (count = NILP (count) ? 1 : count);

since count is an optional argument.  "count = Fprefix_numeric_value (count)" seems 
wrong; the only non-integer argument that should be allowed is nil.

History
Date	User	Action	Args
2009-08-18 08:25:48	stephen	create