Title [Bug: 21.5-b28] [PATCH]
Type patch Module core code 21.4, core code 21.5
Severity inconvenience Platform N/A
Keywords has patch Nosy List jpw, stephen
These controls should only be changed by committers and tracker administrators.
Status assigned   Reason
Superseder   Submitted 2008-08-19.01:00:55
Priority normal   Assigned To

Created on 2008-11-29.06:23:28 by jpw, last changed 2009-03-06.14:27:58 by stephen.

msg871 [hidden] ([hidden]) Date: 2008-11-29.06:23:28
  Message-ID: <uhc9hzum0.fsf@FILTH.SHOOTYBANGBANG.COM>

The XEmacs  is: XEmacs 21.5-b28 "fuki"  (+CVS-20070925) configured for

(user-variable-p 'garbage-collection-messages) returns nil, but I
don't think it should.

Of course, there's no askterisk in the variable's docstring, so maybe
that should be fixed.

More importantly, I think `user-variable-p' should return non-nil for
Customizable variables, checking by doing what `custom-variable-p'

That how GNU Emacs works.  Oh, in addition, it returns non-nil if
VARIABLE is an alias for another user variable.

Here's something pinched from GNU Emacs that could be installed, but I
don't have an SDK and can't even say whether it compiles:

diff -u c:\src\xemacs-21.5\src\eval.c~ c:\src\xemacs-21.5\src\eval.c
--- c:\src\xemacs-21.5\src\eval.c~	2008-08-19 01:43:53.828125000 +0100
+++ c:\src\xemacs-21.5\src\eval.c	2008-08-19 01:43:53.859375000 +0100
@@ -1359,8 +1359,9 @@
 DEFUN ("user-variable-p", Fuser_variable_p, 1, 1, 0, /*
 Return t if VARIABLE is intended to be set and modified by users.
 \(The alternative is a variable used internally in a Lisp program.)
-Determined by whether the first character of the documentation
-for the variable is `*'.
+Determined by whether the first character of the documentation for the
+variable is `*' or whether the variable is customizable; see
+also `custom-variable-p'.
@@ -1376,7 +1377,10 @@
      (CONSP (documentation)
       && STRINGP (XCAR (documentation))
       && INTP (XCDR (documentation))
-      && XINT (XCDR (documentation)) < 0)) ?
+      && XINT (XCDR (documentation)) < 0)) ||
+    /* Customizable?  See `custom-variable-p'.  */
+    (!NILP (Fget (variable, intern ("standard-value"))))
+    || (!NILP (Fget (variable, intern ("custom-autoload")))) ?
     Qt : Qnil;

XEmacs-Beta mailing list
XEmacs-Beta at
Date User Action Args
2009-03-06 14:27:58stephensetkeyword: + has patch
2009-03-06 14:22:54stephensetstatus: assigned
assignedto: stephen
severity: inconvenience
platform: + N/A
nosy: + stephen
type: patch
module: + core code 21.4, core code 21.5
priority: normal
2008-11-29 06:23:28jpwcreate