Issue422

classification
Title [Bug: 21.5-b28] mswindows-short/long-file-name builtins are erroneously declared interactive
Type defect Module core code 21.4, core code 21.5
Severity inelegant Platform N/A
Keywords has patch Nosy List jpw
explanation
process
These controls should only be changed by committers and tracker administrators.
Status verified   Reason
Superseder   Submitted 2008-07-20.00:50:15
Priority cosmetic   Assigned To

Created on 2008-11-29.06:22:39 by jpw, last changed 2009-03-06.14:27:33 by stephen.

Messages
msg1070 [hidden] ([hidden]) Date: 2009-03-06.14:27:33
  Message-ID: <1236349653.57.0.534011351985.issue422@xemacs.org>
Need to check if this is relevant to 21.4 (and Vin wants it).
msg866 [hidden] ([hidden]) Date: 2008-11-29.06:22:39
  Message-ID: <vdz1xttk.fsf@pobox.com>
================================================================
Dear Bug Team!

M-x mswindows[TAB] offered a couple of weird commpletions, namely
`mswindows-short-file-name' and `mswindows-long-file-name'.  They
shouldn't have an interactive spec, at least until they do something
useful interactively.

Here's the fix:

2008-07-20  John Paul Wallington  <jpw at pobox.com>

	* nt.c (Fmswindows_short_file_name, Fmswindows_long_file_name):
	Remove their interactive specs; they shouldn't be called interactively.

diff -u c:\src\xemacs-21.5\src\nt.c~ c:\src\xemacs-21.5\src\nt.c
--- c:\src\xemacs-21.5\src\nt.c~	Sun Jul 20 01:14:49 2008
+++ c:\src\xemacs-21.5\src\nt.c	Sun Jul 20 01:14:49 2008
@@ -2063,7 +2063,7 @@
 /* Some miscellaneous functions that are Windows specific, but not GUI
    specific (ie. are applicable in terminal or batch mode as well).  */

-DEFUN ("mswindows-short-file-name", Fmswindows_short_file_name, 1, 1, "", /*
+DEFUN ("mswindows-short-file-name", Fmswindows_short_file_name, 1, 1, 0, /*
   Return the short file name version (8.3) of the full path of FILENAME.
 If FILENAME does not exist, return nil.
 All path elements in FILENAME are converted to their short names.
@@ -2092,7 +2092,7 @@
 }

-DEFUN ("mswindows-long-file-name", Fmswindows_long_file_name, 1, 1, "", /*
+DEFUN ("mswindows-long-file-name", Fmswindows_long_file_name, 1, 1, 0, /*
   Return the long file name version of the full path of FILENAME.
 If FILENAME does not exist, return nil.
 All path elements in FILENAME are converted to their long names.

================================================================

System Info to help track down your bug:
---------------------------------------

OS version:

Microsoft Windows XP [Version 5.1.2600]

OS: Windows_NT

XEmacs 21.5-b28 "fuki" (+CVS-20070925) configured for `i586-pc-win32'.

  Building XEmacs using "nmake".

  Building XEmacs using make flags "                  ".

  Building XEmacs in source tree "c:\\XEmacsBuild\\xemacs-21.5-2007-09-26".

  For src, using compiler "cl -nologo -W3 -DSTRICT  -Zi -Od -MD -c -TP  -Ic:\XEmacsBuild\xemacs-21.5-2007-09-26\nt\inc -Ic:\XEmacsBuild\xemacs-21.5-2007-09-26\src  -I"e:/cygwin/usr/local/src\xpm-3.4k" -I"e:/cygwin/usr/local/src\xpm-3.4k\lib" -I"e:/cygwin/usr/local/src\libpng-1.2.8" -I"e:/cygwin/usr/local/src/zlib" -I"e:/cygwin/usr/local/src/tiff-3.7.3\libtiff" -I"e:/cygwin/usr/local/src\jpeg-6b" -I"e:/cygwin/usr/local/src/zlib"  -DHAVE_MS_WINDOWS -DHAVE_MENUBARS -DHAVE_SCROLLBARS -DHAVE_TOOLBARS -DHAVE_WIDGETS -DHAVE_DIALOGS -DHAVE_XPM -DFOR_MSW -DHAVE_GIF -DHAVE_PNG -DHAVE_TIFF -DHAVE_JPEG -DHAVE_ZLIB -DHAVE_NATIVE_SOUND -DMULE -DERROR_CHECK_ALL -DPDUMP -DUSE_KKCC -DSYSTEM_MALLOC -DDEBUG_XEMACS -D_DEBUG  -DWIN32_LEAN_AND_MEAN -DWIN32_NATIVE -Demacs  -DHAVE_CONFIG_H -DPATH_VERSION=\"21.5-b28\"		 -DPATH_PROGNAME=\"xemacs\"				 -DEMACS_VERSION=\"21.5-b28\"		 -DEMACS_PROGNAME=\"xemacs\" -DSTACK_TRACE_EYE_CATCHER=xemacs_21_5_b28_i586_pc_win32 -DPATH_PREFIX=\"..\"  -DEMACS_MAJOR_!
 VERSION=21  -DEMACS_MINOR_VERSION=5  -DEMACS_BETA_VERSION=28   -DXEMACS_CODENAME=\""fuki"\"  -DXEMACS_EXTRA_NAME=\"(+CVS-20070925)\"  -DEMACS_CONFIGURATION=\"i586-pc-win32\"".

  For lib-src, using compiler "cl -nologo -W3 -DSTRICT  -Zi -Od -MD -Ic:\XEmacsBuild\xemacs-21.5-2007-09-26\lib-src -Ic:\XEmacsBuild\xemacs-21.5-2007-09-26\src -DHAVE_CONFIG_H -DWIN32_NATIVE".

  Compiling as C++.

  Installing XEmacs in "c:/XEmacsBuild/installed/2007-09-26/XEmacs-21.5-b28".

  Compiling in support for Microsoft Windows native GUI.

  Compiling in international (MULE) support.

  Compiling in support for XPM images.

  Compiling in support for GIF images.

  Compiling in support for PNG images.

  Compiling in support for TIFF images.

  Compiling in support for JPEG images.

  Compiling in support for GZIP compression/decompression.

  Compiling in support for toolbars.

  Compiling in support for dialogs.

  Compiling in support for widgets.

  Compiling in support for native sounds.

  Using portable dumper.

  Using system malloc.

  Using DLL version of C runtime library.

  Compiling in extra internal error-checking.

  NOTE: ---------------------------------------------------------

  NOTE: Compiling in support for runtime error-checking.

  NOTE: XEmacs will run noticeably more slowly as a result.

  NOTE: Error-checking is on by default for XEmacs beta releases.

  NOTE: ---------------------------------------------------------

  Compiling in debugging support (no slowdown).

  Using new experimental GC mark algorithms.

Load-Path Lisp Shadows:
----------------------
(c:/src/vm-8.1.0-devo-571/lisp\vcard c:\Program
Files\XEmacs\xemacs-packages\lisp\gnus\vcard c:\Documents and
Settings\jpw\elisp\compface c:\Program
Files\XEmacs\xemacs-packages\lisp\gnus\compface c:\Documents and
Settings\jpw\elisp\ibuffer c:\Program
Files\XEmacs\xemacs-packages\lisp\ibuffer\ibuffer c:\Documents and
Settings\jpw\elisp\ibuf-macs c:\Program
Files\XEmacs\xemacs-packages\lisp\ibuffer\ibuf-macs c:\Documents and
Settings\jpw\elisp\ibuf-ext c:\Program
Files\XEmacs\xemacs-packages\lisp\ibuffer\ibuf-ext
c:/src/vm-8.1.0-devo-571/lisp\vm c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm
c:/src/vm-8.1.0-devo-571/lisp\vm-window c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-window
c:/src/vm-8.1.0-devo-571/lisp\vm-virtual c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-virtual
c:/src/vm-8.1.0-devo-571/lisp\vm-version c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-version
c:/src/vm-8.1.0-devo-571/lisp\vm-vars c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-vars
c:/src/vm-8.1.0-devo-571/lisp\vm-user c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-user
c:/src/vm-8.1.0-devo-571/lisp\vm-undo c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-undo
c:/src/vm-8.1.0-devo-571/lisp\vm-toolbar c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-toolbar
c:/src/vm-8.1.0-devo-571/lisp\vm-thread c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-thread
c:/src/vm-8.1.0-devo-571/lisp\vm-summary c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-summary
c:/src/vm-8.1.0-devo-571/lisp\vm-startup c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-startup
c:/src/vm-8.1.0-devo-571/lisp\vm-sort c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-sort
c:/src/vm-8.1.0-devo-571/lisp\vm-search c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-search
c:/src/vm-8.1.0-devo-571/lisp\vm-save c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-save
c:/src/vm-8.1.0-devo-571/lisp\vm-reply c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-reply
c:/src/vm-8.1.0-devo-571/lisp\vm-pop c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-pop
c:/src/vm-8.1.0-devo-571/lisp\vm-page c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-page
c:/src/vm-8.1.0-devo-571/lisp\vm-mouse c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-mouse
c:/src/vm-8.1.0-devo-571/lisp\vm-motion c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-motion
c:/src/vm-8.1.0-devo-571/lisp\vm-misc c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-misc
c:/src/vm-8.1.0-devo-571/lisp\vm-minibuf c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-minibuf
c:/src/vm-8.1.0-devo-571/lisp\vm-mime c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-mime
c:/src/vm-8.1.0-devo-571/lisp\vm-message c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-message
c:/src/vm-8.1.0-devo-571/lisp\vm-menu c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-menu
c:/src/vm-8.1.0-devo-571/lisp\vm-mark c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-mark
c:/src/vm-8.1.0-devo-571/lisp\vm-macro c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-macro
c:/src/vm-8.1.0-devo-571/lisp\vm-license c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-license
c:/src/vm-8.1.0-devo-571/lisp\vm-imap c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-imap
c:/src/vm-8.1.0-devo-571/lisp\vm-folder c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-folder
c:/src/vm-8.1.0-devo-571/lisp\vm-edit c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-edit
c:/src/vm-8.1.0-devo-571/lisp\vm-digest c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-digest
c:/src/vm-8.1.0-devo-571/lisp\vm-delete c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-delete
c:/src/vm-8.1.0-devo-571/lisp\vm-crypto c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-crypto
c:/src/vm-8.1.0-devo-571/lisp\vm-autoload c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\vm-autoload
c:/src/vm-8.1.0-devo-571/lisp\tapestry c:\Program
Files\XEmacs\xemacs-packages\lisp\vm\tapestry c:\Program
Files\XEmacs\xemacs-packages\lisp\xemacs-base\regexp-opt c:\Program
Files\XEmacs\XEmacs-21.5-b28\lisp\regexp-opt c:\Program
Files\XEmacs\xemacs-packages\lisp\xemacs-base\easy-mmode c:\Program
Files\XEmacs\XEmacs-21.5-b28\lisp\easy-mmode)

Internationalization Settings:
-------------------------

Environment:

  Value of LC_ALL      : nil
  Value of LC_COLLATE  : nil
  Value of LC_CTYPE    : nil
  Value of LC_MESSAGES : nil
  Value of LC_MONETARY : nil
  Value of LC_NUMERIC  : nil
  Value of LC_TIME     : nil
  Value of LANG        : nil

Lisp locale settings:

  current-language-environment      => "English"
  default-buffer-file-coding-system => mswindows-multibyte-dos
  default-process-coding-system     => (undecided . mswindows-multibyte-system-default)
  (current-locale)                  => "English_United States.1252"
  keyboard-coding-system            => mswindows-multibyte-system-default
  terminal-coding-system            => mswindows-multibyte-system-default
  (coding-priority-list)            =>
    (no-conversion utf-16-little-endian-bom utf-16-bom utf-8-bom iso-7
    utf-8 iso-8-1 iso-8-2 iso-8-designate iso-lock-shift shift-jis
    big5 utf-16-little-endian utf-16 ucs-4)

Coding system aliases:

  'native                              is aliased to mswindows-multibyte-system-default-dos
  'file-name                           is aliased to native
  'mswindows-multibyte-system-default  is not a coding system alias

Installed XEmacs Packages:
-------------------------
(xetla ver: 1.01 upstream: steve at eicq.org--2005/xetla--main--1.1--version-0)
(xemacs-devel ver: 1.76 upstream: No-Upstream-Ver)
(xemacs-base ver: 2.11 upstream: No-Upstream-Ver)
(w3 ver: 1.34 upstream: 4.0pre47)
(vm ver: 7.24 upstream: 7.17)
(viper ver: 1.58 upstream: 3.09)
(vhdl ver: 1.22 upstream: 3.33.12)
(vc ver: 1.42 upstream: No-Upstream-Ver)
(tramp ver: 1.39 upstream: 2.0.56)
(time ver: 1.14 upstream: 1.17)
(textools ver: 1.15 upstream: No-Upstream-Ver)
(text-modes ver: 1.95 upstream: No-Upstream-Ver)
(texinfo ver: 1.3 upstream: No-Upstream-Ver)
(supercite ver: 1.21 upstream: 3.55x3)
(speedbar ver: 1.28 upstream: 0.14beta4)
(sounds-wav ver: 1.12 upstream: No-Upstream-Ver)
(sieve ver: 1.18 upstream: No-Upstream-Ver)
(sh-script ver: 1.22 upstream: 2.0f)
(sgml ver: 1.11 upstream: No-Upstream-Ver)
(semantic ver: 1.2 upstream: 1.4.4)
(scheme ver: 1.16 upstream: No-Upstream-Ver)
(sasl ver: 1.16 upstream: 1.14.4)
(re-builder ver: 1.05 upstream: 1.20)
(python-modes ver: 1.09 upstream: No-Upstream-Ver)
(psgml ver: 1.45 upstream: 1.3.2)
(ps-print ver: 1.11 upstream: 6.5.6)
(prog-modes ver: 2.14 upstream: No-Upstream-Ver)
(perl-modes ver: 1.1 upstream: No-Upstream-Ver)
(pcomplete ver: 1.04 upstream: 1.1.6)
(pcl-cvs ver: 1.67 upstream: R-2_9_9)
(pc ver: 1.28 upstream: No-Upstream-Ver)
(os-utils ver: 1.39 upstream: No-Upstream-Ver)
(net-utils ver: 1.53 upstream: N/A)
(mmm-mode ver: 1.02 upstream: 0.4.7)
(mh-e ver: 1.29 upstream: 7.4.2)
(mailcrypt ver: 2.14 upstream: 3.5.8)
(mail-lib ver: 1.79 upstream: No-Upstream-Ver)
(jde ver: 1.51 upstream: 2.3.3)
(ispell ver: 1.32 upstream: 3.6)
(igrep ver: 1.15 upstream: 2.111)
(ibuffer ver: 1.09 upstream: No-Upstream-Ver)
(hm--html-menus ver: 1.24 upstream: 5.9)
(gnus ver: 1.91 upstream: 5.10.8)
(fsf-compat ver: 1.15 upstream: No-Upstream-Ver)
(fortran-modes ver: 1.05 upstream: No-Upstream-Ver)
(footnote ver: 1.16 upstream: 0.18x)
(eshell ver: 1.12 upstream: 2.4.1)
(emerge ver: 1.11 upstream: No-Upstream-Ver)
(elib ver: 1.11 upstream: 1.0)
(eieio ver: 1.05 upstream: 0.17)
(efs ver: 1.33 upstream: 1.23)
(edit-utils ver: 2.38 upstream: No-Upstream-Ver)
(ediff ver: 1.71 upstream: 2.75)
(edebug ver: 1.22 upstream: No-Upstream-Ver)
(ecrypto ver: 0.2 upstream: 2.0)
(ecb ver: 1.22 upstream: 2.31)
(dired ver: 1.17 upstream: 7.13)
(debug ver: 1.18 upstream: No-Upstream-Ver)
(cc-mode ver: 1.45 upstream: 5.30.10)
(calc ver: 1.26 upstream: 2.02fX3)
(c-support ver: 1.22 upstream: No-Upstream-Ver)

Features:
--------

(xemacsbug shadow diff diff-mode cc-mode cc-fonts cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs regexp-opt efs-cu
view-less view hyper-apropos dired-faces dired-xemacs dired
timer-funcs eldoc timer compface message mml mml-sec mml-smime smime
dig mm-decode mm-bodies mm-encode mailcap lpr mail-parse rfc2045
rfc2231 rfc2047 qp ietf-drums mail-abbrevs sendmail rfc822 mailheader
canlock sha1 executable hex-util gnus gnus-ems gnus-xmas messagexmas
nnheader nnheaderxm gnus-util netrc time-date mail-utils mm-util
mail-prsvr wid-edit font-lock cus-face ansi-color jka-compr
pending-del blink-cursor xetla-autoloads xemacs-devel-autoloads
xemacs-base-autoloads w3-autoloads vm-autoloads viper-autoloads
vhdl-autoloads vc-autoloads tramp-autoloads time-autoloads
textools-autoloads text-modes-autoloads texinfo-autoloads
supercite-autoloads speedbar-autoloads sounds-wav-autoloads
sieve-autoloads sh-script-autoloads sgml-autoloads semantic-autoloads
scheme-autoloads sasl-autoloads re-builder-autoloads
python-modes-autoloads psgml-autoloads ps-print-autoloads
prog-modes-autoloads perl-modes-autoloads pcomplete-autoloads
pcl-cvs-autoloads pc-autoloads os-utils-autoloads net-utils-autoloads
mmm-mode-autoloads mh-e-autoloads mailcrypt-autoloads
mail-lib-autoloads jde-autoloads ispell-autoloads igrep-autoloads
ibuffer-autoloads hm--html-menus-autoloads gnus-autoloads
fsf-compat-autoloads fortran-modes-autoloads footnote-autoloads
eshell-autoloads emerge-autoloads elib-autoloads eieio-autoloads
efs-autoloads edit-utils-autoloads ediff-autoloads edebug-autoloads
ecrypto-autoloads ecb-autoloads dired-autoloads debug-autoloads
cc-mode-autoloads calc-autoloads c-support-autoloads mule-autoloads
auto-autoloads auto-show fontl-hooks canna-leim tibetan slovenian
czech romanian lao devanagari indian cyrillic code-cmds gutter-items
menubar-items x-menubar dragdrop mode-motion mouse behavior itimer
auto-save lisp-mode easymenu easy-mmode iso8859-1 page buff-menu
lib-complete loadhist cus-file derived newcomment rsz-minibuf env
text-props frame obsolete cus-start custom widget cl-extra cl cl-19
packages backquote unicode mswindows-scrollbars mswindows toolbar
native-sound scrollbar network-streams subprocesses
menu-accelerator-support menubar md5 xemacs mule gutter tiff png gif
jpeg xpm xbm lisp-float-type file-coding dde windows-nt dragdrop-api
dialog devices window-system base64)

Recent keystrokes:
-----------------

[elided]

Recent messages (most recent first):
-----------------------------------

[elided]

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta at xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
History
Date User Action Args
2009-03-06 14:27:33stephensetstatus: verified
priority: cosmetic
severity: inelegant
keyword: + has patch
platform: + N/A
type: defect
messages: + msg1070
module: + core code 21.4, core code 21.5
2008-11-29 06:22:39jpwcreate