On Jan 8, 2008 12:05 AM, Marcus Crestani
<crestani@informatik.uni-tuebingen.de> wrote:
> Your patch allows me to build the carbon2 branch with -std=c99 on
> Leopard (10.5.1).  Thanks, Jerry!

Hmmmm, interesting.  All those bare 'inline' keywords in the sources
still make me nervous, but apparently are not breaking the build for
anyone.  I'm going to commit this patch for now, to unbreak the build
for Mac OS X users, but I'm going to study the issue a little more
deeply before I do a mass macroizing and an update to the Internals
manual.

Thanks for trying out the patch, Marcus.
-- 
Jerry James
http://loganjerry.googlepages.com/

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta@xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta

JJ> I can't seem to reproduce the C99 + inline problem on my machine.
JJ> If I'm not mistaken, all of the reports of this problem so far
JJ> have come from Mac OS X users.  Would one of you please try
JJ> applying this patch and building with -std=c99 or -std=gnu99 and
JJ> see if it works?

Your patch allows me to build the carbon2 branch with -std=c99 on
Leopard (10.5.1).  Thanks, Jerry!

I can't seem to reproduce the C99 + inline problem on my machine.  If
I'm not mistaken, all of the reports of this problem so far have come
from Mac OS X users.  Would one of you please try applying this patch
and building with -std=c99 or -std=gnu99 and see if it works?

diff -r 4363b75330ca src/config.h.in
--- a/src/config.h.in	Mon Jan 07 12:07:55 2008 -0700
+++ b/src/config.h.in	Mon Jan 07 12:34:24 2008 -0700
@@ -1086,7 +1086,8 @@ extern "C" {
    Use `inline static' to define inline functions in .c files.
    See the Internals manual for examples and more information. */

-#if defined (__cplusplus) || ! defined (__GNUC__) || ! defined(emacs)
+#if __STDC_VERSION__ >= 199901L || defined (__cplusplus) || \
+    ! defined (__GNUC__) || ! defined(emacs)
 # define INLINE_HEADER inline static
 #elif defined (DONT_EXTERN_INLINE_HEADER_FUNCTIONS)
 # define INLINE_HEADER inline

Thanks!
-- 
Jerry James
http://loganjerry.googlepages.com/

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta@xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta