Issue90

classification
Title [Q] (was Re: [Bug: 21.5-b28]
Type Module
Severity Platform
Keywords
explanation
process
These optional controls are only of interest to committers and tracker administrators.
Status chatting   Reason
Superseder   Submitted 2007-12-17.22:00:22
Priority   Assigned To
Nosy List  

Created on 2008-01-19.04:58:05 by stephen, last changed 2008-01-19.06:43:12 by aidan.

Messages
msg332 [hidden] ([hidden]) Date: 2008-01-19.06:43:11
  Message-ID: <18279.27520.652544.140195@parhasard.net>
Ar an t-ochtú lá déag de mí na Nollaig, scríobh Stephen J. Turnbull: 

 > QUERY
 > 
 > Aidan Kehoe writes:
 > 
 >  > Anyway, given that we know it's happened, and that the _trapping_problems
 >  > code should prevent it happening in the future, does anyone have any
 >  > objections to this? 
 > 
 > Yes.  We *want* bugs that we don't understand to happen, so that we
 > can diagnose and fix them.  I think this should be an
 > assert(!in_redisplay) or whatever the idiom is.  Or if
 > _trapping_problems has an abort option, use it.
 > 
 > If we discover a valid reason for delete_frame to get called in
 > redisplay,

My point was that Thomas just did. We don’t know the details, and would be
very lucky to learn them, but I’m pretty sure he didn’t attach to the
process with a debugger, put a breakpoint in redisplay, and call
delete_frame_internal himself. Unless those wily SXEmacs folk put him up to
it to sabotage our development.

 > then we will need to condition on that to prevent the
 > hook from being called.  Or, more likely, find a way to postpone the
 > delete_frame until we're out of the redisplay critical section.
msg110 [hidden] ([hidden]) Date: 2008-01-19.04:58:05
  Message-ID: <87wsrddls9.fsf@uwakimon.sk.tsukuba.ac.jp>
QUERY

Aidan Kehoe writes:

 > Anyway, given that we know it's happened, and that the _trapping_problems
 > code should prevent it happening in the future, does anyone have any
 > objections to this? 

Yes.  We *want* bugs that we don't understand to happen, so that we
can diagnose and fix them.  I think this should be an
assert(!in_redisplay) or whatever the idiom is.  Or if
_trapping_problems has an abort option, use it.

If we discover a valid reason for delete_frame to get called in
redisplay, then we will need to condition on that to prevent the
hook from being called.  Or, more likely, find a way to postpone the
delete_frame until we're out of the redisplay critical section.

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta@xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
History
Date User Action Args
2008-01-19 06:43:12aidansetstatus: new -> chatting
messages: + msg332
2008-01-19 04:58:05stephencreate