Issue202

classification
Title [COMMIT] Add xemacs-base to the build REQUIRES list for elib.
Type defect Module elib
Severity inconvenience Platform N/A
Keywords
explanation
process
These optional controls are only of interest to committers and tracker administrators.
Status committed   Reason fixed
Superseder   Submitted 2008-01-01.00:52:17
Priority normal   Assigned To
Nosy List aidan  

Created on 2008-01-19.06:43:13 by acs, last changed 2008-05-12.12:41:00 by aidan.

Messages
msg345 [hidden] ([hidden]) Date: 2008-01-19.06:43:13
  Message-ID: <18298.21047.922932.249774@parhasard.net>
Ar an t-aonú lá is triochad de mí na Nollaig, scríobh Vin Shelton: 

 > Aidan -
 > 
 > It looks like you made a change in elib.  The package build is
 > currently failing:

[...]

 >   # (condition-case ... . error)
 >   # (catch top-level ...)
 > >>Error occurred processing unique.el: Cannot open load file: "sort"
 > 
 > make[2]: *** [unique.elc] Error 1
 > make[2]: Leaving directory
 > `/opt/build/xemacs-packages-2007-12-31/xemacs-packages/elib'
 > make[1]: *** [elib/bytecompile.target] Error 2
 > make[1]: Leaving directory
 > `/opt/build/xemacs-packages-2007-12-31/xemacs-packages'
 > make: *** [xemacs-packages/bytecompile.target] Error 2
 > 
 > Thanks for fixing this.

Done, as far as I can work out, given that semantic and cogre and various
;;;###autoloadimmediate cookes are still wreaking their havoc. Please get
back to me directly if it stil doesn’t build for you. 

APPROVE COMMIT

NOTE: This patch has been committed.

xemacs-packages/elib/ChangeLog addition:

2008-01-01  Aidan Kehoe  <kehoea@parhasard.net>

	* Makefile (REQUIRES):
	Add xemacs-base to the build REQUIRES list for elib, so the build
	works. Thank you Vin. 

XEmacs Packages source patch:
Diff command:   cvs -q diff -Nu
Files affected: xemacs-packages/elib/Makefile
===================================================================
RCS

Index: xemacs-packages/elib/Makefile
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/elib/Makefile,v
retrieving revision 1.21
diff -u -u -r1.21 Makefile
--- xemacs-packages/elib/Makefile	2007/12/31 21:36:47	1.21
+++ xemacs-packages/elib/Makefile	2008/01/01 14:44:11
@@ -24,7 +24,7 @@
 MAINTAINER = XEmacs Development Team <xemacs-beta@xemacs.org>
 PACKAGE = elib
 PKG_TYPE = single-file
-REQUIRES = 
+REQUIRES = xemacs-base # sort.el is used in unique.el
 CATEGORY = standard

 EXTRA_SOURCES = NEWS README
msg344 [hidden] ([hidden]) Date: 2008-01-19.06:43:13
  Message-ID: <20a807210712311652w2e06e049u8022d8bd1b3f4439@mail.gmail.com>
Aidan -

It looks like you made a change in elib.  The package build is
currently failing:

Compiling /opt/build/xemacs-packages-2007-12-31/xemacs-packages/elib/unique.el...
Loading /opt/xemacs-21.5-2007-12-29/share/xemacs-21.5-b28/lisp/cl-macs.elc...
While compiling toplevel forms in file
/opt/build/xemacs-packages-2007-12-31/xemacs-packages/elib/unique.el:
  !! File error (("Cannot open load file" "sort"))
  backtrace(nil t)
  # bind (error-info)
  byte-compile-report-error((file-error "Cannot open load file" "sort"))
  # bind (error-info)
  #<compiled-function (error-info) "...(4)" [error-info
byte-compile-report-error] 2>((file-error "Cannot open load file"
"sort"))
  signal(file-error ("Cannot open load file" "sort"))
  # bind (path handler filename nosuffix nomessage noerror file)
  load("sort" nil require nil)
  # (unwind-protect ...)
  require(sort)
  (progn (require (quote sort)))
  eval((progn (require (quote sort))))
  # bind (sym def G62776)
  # (unwind-protect ...)
  # bind (save-macro-environment form)
  byte-compile-eval((progn (require (quote sort))))
  (list (quote quote) (byte-compile-eval (cons (quote progn) body)))
  # bind (body)
  (lambda (&rest body) (list (quote quote) (byte-compile-eval (cons
(quote progn) body))))((require (quote sort)))
  #<subr macroexpand-internal>((eval-when-compile (require (quote
sort))) ((byte-compiler-options lambda (&rest forms) (apply (quote
byte-compiler-options-handler) forms)) (eval-when-compile lambda
(&rest body) (list (quote quote) (byte-compile-eval (cons (quote
progn) body)))) (eval-and-compile lambda (&rest body)
(byte-compile-eval (cons (quote progn) body)) (cons (quote progn)
body))))
  # bind (cl-macro-environment cl-env cl-macro)
  macroexpand((eval-when-compile (require (quote sort)))
((byte-compiler-options lambda (&rest forms) (apply (quote
byte-compiler-options-handler) forms)) (eval-when-compile lambda
(&rest body) (list (quote quote) (byte-compile-eval (cons (quote
progn) body)))) (eval-and-compile lambda (&rest body)
(byte-compile-eval (cons (quote progn) body)) (cons (quote progn)
body))))
  # bind (byte-compile-current-form handler form)
  byte-compile-file-form((eval-when-compile (require (quote sort))))
  # (unwind-protect ...)
  #<compiled-function nil "...(43)" [byte-compile-unresolved-functions
byte-compile-inbuffer 1 " 	\n" nil looking-at ";"
byte-compile-file-form read byte-compile-flush-pending
byte-compile-warn-about-unresolved-functions] 3>()
  # (unwind-protect ...)
  call-with-condition-handler(#<compiled-function (error-info)
"...(4)" [error-info byte-compile-report-error] 2> #<compiled-function
nil "...(43)" [byte-compile-unresolved-functions byte-compile-inbuffer
1 " 	\n" nil looking-at ";" byte-compile-file-form read
byte-compile-flush-pending
byte-compile-warn-about-unresolved-functions] 3>)
  # (unwind-protect ...)
  # bind (byte-compile-warnings-beginning byte-compile-point-max-prev
byte-compile-log-buffer byte-compile-macro-environment
byte-compile-function-environment byte-compile-autoload-environment
byte-compile-unresolved-functions byte-compile-bound-variables
byte-compile-free-references byte-compile-free-assignments
byte-compile-verbose byte-optimize byte-compile-emacs19-compatibility
byte-compile-dynamic byte-compile-dynamic-docstrings
byte-compile-warnings byte-compile-file-domain byte-compile-outbuffer
float-output-format case-fold-search print-length print-level
byte-compile-constants byte-compile-variables byte-compile-tag-number
byte-compile-depth byte-compile-maxdepth byte-compile-output eval
filename byte-compile-inbuffer)
  byte-compile-from-buffer(#<buffer " *Compiler Input*">
"/opt/build/xemacs-packages-2007-12-31/xemacs-packages/elib/unique.el")
  # bind (byte-compile-current-file target-file input-buffer
output-buffer byte-compile-dest-file load filename)
  byte-compile-file("unique.el")
  byte-code("..." [file byte-compile-file t] 2)
  # (condition-case ... . ((error (byte-code
"ÂÃ!ˆÂ!ˆÂÄ!ˆÅÆ!«‡Æ	Ç\"ˆª'Â	@ÈN(R)‚	@!ˆÉÊ	A\"ˆÂË!ˆÇ‡" [file err princ
">>Error occurred processing " ": " fboundp display-error nil
error-message mapcar #<compiled-function (x) "...(8)" [x princ " "
prin1] 2> "\n"] 3))))
  # bind (file)
  batch-byte-compile-1("unique.el")
  # bind (error file-to-process)
  batch-byte-compile-one-file()
  # bind (error)
  batch-byte-compile()
  # bind (arg)
  command-line-do-funcall("-f")
  # bind (dir file-count line end-of-options file-p arg tem)
  command-line-1()
  # bind (command-line-args-left)
  co
Donemmand-line()
  # bind (error-data)
  normal-top-level()
  # (condition-case ... . error)
  # (catch top-level ...)
>>Error occurred processing unique.el: Cannot open load file: "sort"

make[2]: *** [unique.elc] Error 1
make[2]: Leaving directory
`/opt/build/xemacs-packages-2007-12-31/xemacs-packages/elib'
make[1]: *** [elib/bytecompile.target] Error 2
make[1]: Leaving directory
`/opt/build/xemacs-packages-2007-12-31/xemacs-packages'
make: *** [xemacs-packages/bytecompile.target] Error 2

Thanks for fixing this.

Regards,
  Vin

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta@xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
History
Date User Action Args
2008-05-12 12:41:00aidansetstatus: chatting -> committed
severity: inconvenience
platform: + N/A
nosy: + aidan
module: + elib
priority: normal
assignedto: aidan
reason: fixed
type: defect
2008-01-19 06:43:13aidansetstatus: new -> chatting
messages: + msg345
title: Package build failure -> [COMMIT] Add xemacs-base to the build REQUIRES list for elib.
2008-01-19 06:43:13acscreate