Issue191

classification
Title 21.5 Windows jpeg patch
Type patch Module core code 21.5
Severity inconvenience Platform mswindows
Keywords
explanation
process
These optional controls are only of interest to committers and tracker administrators.
Status committed   Reason fixed
Superseder   Submitted 2007-12-06.19:05:22
Priority normal   Assigned To
Nosy List aidan  

Created on 2008-01-19.06:43:09 by Ron.Isaacson, last changed 2008-05-13.11:50:50 by aidan.

Files
File name Uploaded Type Edit Remove
unnamed Ron.Isaacson, 2008-01-19.06:43:09 text/plain
windows-jpeg.patch Ron.Isaacson, 2008-01-19.06:43:09 application/octet-stream
Messages
msg307 [hidden] ([hidden]) Date: 2008-01-19.06:43:09
  Message-ID: <3ggy7bqc7ec.wl_Ron.Isaacson@morganstanley.com>
Jerry James wrote:
> 
> On Dec 11, 2007 8:32 PM, Ron Isaacson <Ron.Isaacson@morganstanley.com> wrote:
> > Aidan Kehoe wrote:
> > > Okay, I don't actually see the problem locally, but the patch seems sensible
> > > enough and it doesn't break the build or anything of the sort, so I've gone
> > > ahead and committed it. What exactly are the versions of the various
> > > libraries that break for you?
> >
> > Here are all of the external libs I'm using -- each is a local build
> > from source:
> >
> >   xpm  -> 3.4k
> >   png  -> 1.2.8
> >   zlib -> 1.2.3
> >   jpeg -> 6b.3
> >   tiff -> 3.7.2
> >
> > I read that this can happen if there's a mismatch between the
> > build-time and runtime versions of libjpeg, although on Windows
> > everything is static, so that shouldn't be an issue, right?
> >
> > I can reproduce this using:
> >
> >   (glyph-image-instance
> >     (make-glyph [jpeg :file "c:/any/image.jpg"]))
> >
> > Without the patch, it always fails with the error message above.
> 
> Can you grab a DLL dependency analyzer [1] and see what it says
> about JPEG DLLs?

Didn't find any at all. None of the dll's had "jpeg" or anything like
it in the name. I did find imgutil.dll and imagehlp.dll from
c:\windows\system32, but that's it.

Would you expect anything different? I don't think there are any JPEG
dll's in my PATH. The path to jpeg/6b.3 in config.inc contains only
libjpeg.lib, which is linked in statically, and best I can tell it
wouldn't even attempt to load a JPEG dll if there were one there.
msg306 [hidden] ([hidden]) Date: 2008-01-19.06:43:09
  Message-ID: <870180fe0712190727k2653c9edrc10cebb3ed73136d@mail.gmail.com>
On Dec 11, 2007 8:32 PM, Ron Isaacson <Ron.Isaacson@morganstanley.com> wrote:
> Aidan Kehoe wrote:
> > Okay, I don't actually see the problem locally, but the patch seems sensible
> > enough and it doesn't break the build or anything of the sort, so I've gone
> > ahead and committed it. What exactly are the versions of the various
> > libraries that break for you?
>
> Here are all of the external libs I'm using -- each is a local build
> from source:
>
>   xpm  -> 3.4k
>   png  -> 1.2.8
>   zlib -> 1.2.3
>   jpeg -> 6b.3
>   tiff -> 3.7.2
>
> I read that this can happen if there's a mismatch between the
> build-time and runtime versions of libjpeg, although on Windows
> everything is static, so that shouldn't be an issue, right?
>
> I can reproduce this using:
>
>   (glyph-image-instance
>     (make-glyph [jpeg :file "c:/any/image.jpg"]))
>
> Without the patch, it always fails with the error message above.

Can you grab a DLL dependency analyzer [1] and see what it says about JPEG DLLs?

[1] For example, http://www.dependencywalker.com/
-- 
Jerry James
http://loganjerry.googlepages.com/

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta@xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
msg305 [hidden] ([hidden]) Date: 2008-01-19.06:43:09
  Message-ID: <3ggr6hs4mfs.wl_Ron.Isaacson@morganstanley.com>
Aidan Kehoe wrote:
> 
>  Ar an séiú lá de mí na Nollaig, scríobh Ron Isaacson:
> 
>  > So I just built 21.5.28 for Windows, and noticed that jpeg glyphs fail
>  > with this error:
>  >
>  >   JPEG parameter struct mismatch: library thinks size is xx, caller
>  >   expects yy
>  >
>  > Google found several hits, including many on libtiff-related lists
>  > that offer the same fix. A patch is attached. (One such message is
>  > referenced in the patch. I can't take credit for the actual fix, just
>  > the Google->XEmacs transform.)
> 
> Okay, I don't actually see the problem locally, but the patch seems sensible
> enough and it doesn't break the build or anything of the sort, so I've gone
> ahead and committed it. What exactly are the versions of the various
> libraries that break for you?

Here are all of the external libs I'm using -- each is a local build
from source:

  xpm  -> 3.4k
  png  -> 1.2.8
  zlib -> 1.2.3
  jpeg -> 6b.3
  tiff -> 3.7.2

I read that this can happen if there's a mismatch between the
build-time and runtime versions of libjpeg, although on Windows
everything is static, so that shouldn't be an issue, right?

I can reproduce this using:

  (glyph-image-instance
    (make-glyph [jpeg :file "c:/any/image.jpg"]))

Without the patch, it always fails with the error message above.
msg304 [hidden] ([hidden]) Date: 2008-01-19.06:43:09
  Message-ID: <18271.8567.546694.528409@parhasard.net>
Ar an séiú lá de mí na Nollaig, scríobh Ron Isaacson: 

 > So I just built 21.5.28 for Windows, and noticed that jpeg glyphs fail
 > with this error:
 > 
 >   JPEG parameter struct mismatch: library thinks size is xx, caller
 >   expects yy
 > 
 > Google found several hits, including many on libtiff-related lists
 > that offer the same fix. A patch is attached. (One such message is
 > referenced in the patch. I can't take credit for the actual fix, just
 > the Google->XEmacs transform.)

Okay, I don’t actually see the problem locally, but the patch seems sensible
enough and it doesn’t break the build or anything of the sort, so I’ve gone
ahead and committed it. What exactly are the versions of the various
libraries that break for you?
msg303 [hidden] ([hidden]) Date: 2008-01-19.06:43:09
  Message-ID: <3ggprxj7ifh.wl_Ron.Isaacson@morganstanley.com>
So I just built 21.5.28 for Windows, and noticed that jpeg glyphs fail
with this error:

  JPEG parameter struct mismatch: library thinks size is xx, caller
  expects yy

Google found several hits, including many on libtiff-related lists
that offer the same fix. A patch is attached. (One such message is
referenced in the patch. I can't take credit for the actual fix, just
the Google->XEmacs transform.)
History
Date User Action Args
2008-05-13 11:50:50aidansetstatus: chatting -> committed
severity: inconvenience
platform: + mswindows
nosy: + aidan
module: + core code 21.5
priority: normal
assignedto: aidan
reason: fixed
type: patch
2008-01-19 06:43:09Ron.Isaacsonsetmessages: + msg307
2008-01-19 06:43:09jamessetmessages: + msg306
2008-01-19 06:43:09Ron.Isaacsonsetmessages: + msg305
2008-01-19 06:43:09aidansetstatus: new -> chatting
messages: + msg304
2008-01-19 06:43:09Ron.Isaacsoncreate