Issue142

classification
Title Calc from CVS Emacs
Type Module
Severity Platform
Keywords
explanation
process
These optional controls are only of interest to committers and tracker administrators.
Status chatting   Reason
Superseder   Submitted 2007-10-29.18:17:56
Priority   Assigned To
Nosy List  

Created on 2008-01-19.06:43:00 by jay.p.belanger, last changed 2008-01-19.06:43:00 by adrian.

Messages
msg194 [hidden] ([hidden]) Date: 2008-01-19.06:43:00
  Message-ID: <d4ux53k5.fsf@mx.qsc.de>
Jay Belanger <jay.p.belanger@gmail.com> writes:

> "Adrian Aichner" <adrian@xemacs.org> writes:
> ...
>> Hello Jay, thanks for contacting us!
>
> You're welcome!  I suppose I should have introduced myself as the 
> Calc maintainer for Emacs.
>
>> Perhaps we could discuss which checks bother you.
>
> None of them, actually.  But if there was no chance of them ever being
> used, I thought they could be eliminated (and make the code slightly
> cleaner).  Since there is the possibility of some code migration, I'll
> leave them in.  However, they will change from looking at the value of 
> `calc-emacs-type-lucid' 
> (whose value is `(not (not (string-match "Lucid" emacs-version)))') 
> to using 
> `(featurep 'xemacs)' 

Yes, that's a good change!

> which is of course better for optimization.  XEmacs's Calc uses the same
> test  (in slightly different places, due I suppose to minor code drift;

Our source changes from GNU Emacs should be preceded by a line like
;; XEmacs change

> I haven't compared them too thoroughly), and I assume also changing it
> to a feature test in XEmacs's Calc wouldn't be a bad idea.

Yes.

>
>> Hopefully someone on XEmacs-Beta@xemacs.org will indicate interested
>> to get XEmacs calc synced up soonish.
>
> If that happens, feel free to get in touch with me with any questions,
> etc.  There have been a few changes in Emacs Calc which I think it would
> be worth adding to the XEmacs version (in my not exactly unbiased
> opinion). 

Great!  Thanks for the offer!

Best regards!

Adrian

>
> Best regards,
> Jay
>
>
msg193 [hidden] ([hidden]) Date: 2008-01-19.06:43:00
  Message-ID: <m3ir4pcla3.fsf@gmail.com>
"Adrian Aichner" <adrian@xemacs.org> writes:
...
> Hello Jay, thanks for contacting us!

You're welcome!  I suppose I should have introduced myself as the 
Calc maintainer for Emacs.

> Perhaps we could discuss which checks bother you.

None of them, actually.  But if there was no chance of them ever being
used, I thought they could be eliminated (and make the code slightly
cleaner).  Since there is the possibility of some code migration, I'll
leave them in.  However, they will change from looking at the value of 
`calc-emacs-type-lucid' 
(whose value is `(not (not (string-match "Lucid" emacs-version)))') 
to using 
`(featurep 'xemacs)' 
which is of course better for optimization.  XEmacs's Calc uses the same
test  (in slightly different places, due I suppose to minor code drift;
I haven't compared them too thoroughly), and I assume also changing it
to a feature test in XEmacs's Calc wouldn't be a bad idea.

> Hopefully someone on XEmacs-Beta@xemacs.org will indicate interested
> to get XEmacs calc synced up soonish.

If that happens, feel free to get in touch with me with any questions,
etc.  There have been a few changes in Emacs Calc which I think it would
be worth adding to the XEmacs version (in my not exactly unbiased
opinion). 

Best regards,
Jay

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta@xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
msg192 [hidden] ([hidden]) Date: 2008-01-19.06:43:00
  Message-ID: <m3odehaip7.fsf@gmail.com>
The version of Calc in CVS Emacs contains about five checks to see if
it is being run under XEmacs, for compatability (although even with
these checks it's doubtful that it would run, as is, in XEmacs).  Is
there going to be any effort to get the Emacs version of Calc working
under XEmacs?  If not, I assume there would be no objections to
removing the checks.

Jay

_______________________________________________
XEmacs-Beta mailing list
XEmacs-Beta@xemacs.org
http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta
History
Date User Action Args
2008-01-19 06:43:00adriansetmessages: + msg194
2008-01-19 06:43:00jay.p.belangersetstatus: new -> chatting
messages: + msg193
2008-01-19 06:43:00jay.p.belangercreate